MarkGaox commented on code in PR #2641:
URL: https://github.com/apache/helix/pull/2641#discussion_r1347783515
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java:
##########
@@ -528,10 +560,7 @@ private List<String> filterInstancesForNextCheck(
String instance = entry.getKey();
try {
StoppableCheck stoppableCheck = entry.getValue().get();
- if (!stoppableCheck.isStoppable()) {
- // put the check result of the failed-to-stop instances
- addStoppableCheck(finalStoppableCheckByInstance, instance,
stoppableCheck);
- }
+ addStoppableCheck(finalStoppableCheckByInstance, instance,
stoppableCheck);
Review Comment:
Why add instances that are stoppable to the finalStoppableCheckByInstance
list? Wouldn't this change stop filtering instances for the next check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
