Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 )
Change subject: IMPALA-6285: Don't print stack trace on RPC errors. ...................................................................... Patch Set 2: Code-Review+2 (2 comments) I'm assuming Sailesh is happy with this based on his previous comment. http://gerrit.cloudera.org:8080/#/c/8788/2/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: http://gerrit.cloudera.org:8080/#/c/8788/2/be/src/runtime/client-cache.h@314 PS2, Line 314: return Status::Expected(msg); This idiom is a bit inefficient - i think it results in three copies of the string - first to construct it, then to copy it into the ErrorMsg, then to copy it into a new ErrorMsg in the status. It probably doesn't really matter though. http://gerrit.cloudera.org:8080/#/c/8788/2/be/src/runtime/client-cache.h@329 PS2, Line 329: VLOG_QUERY << msg.msg() << " rpc: " << typeid(*response).name(); Should we also include the typeid() in the Status? Or is thta overkill? -- To view, visit http://gerrit.cloudera.org:8080/8788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58 Gerrit-Change-Number: 8788 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 07 Dec 2017 17:59:43 +0000 Gerrit-HasComments: Yes
