Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 )
Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns ...................................................................... Patch Set 2: (4 comments) LGTM, had minor comments http://gerrit.cloudera.org:8080/#/c/9140/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9140/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-6311 it's IMPALA-6113 http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.h File be/src/exec/parquet-column-stats.h: http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.h@78 PS2, Line 78: int64_t* Currently it returns a pointer to a member of ColumnChunk. This means that the returned pointer can easily become dangling if the corresponding ColumnChunk object dies. Maybe you could add a comment about it. Or, it could return an int64_t, and -1 would indicate that there are no null_count statistics. http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.cc File be/src/exec/parquet-column-stats.cc: http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.cc@132 PS2, Line 132: const int64_t* ColumnStatsBase::ReadNullCountStat( : const parquet::ColumnChunk& col_chunk) { nit: can fit into one line http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.cc@139 PS2, Line 139: if (stats.__isset.null_count) { : return &stats.null_count; : } nit: can be a one-liner -- To view, visit http://gerrit.cloudera.org:8080/9140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I141317af0e0df30da8f220b29b0bfba364f40ddf Gerrit-Change-Number: 9140 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2018 11:19:53 +0000 Gerrit-HasComments: Yes
