Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 )
Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9140/3/be/src/exec/parquet-column-stats.cc File be/src/exec/parquet-column-stats.cc: http://gerrit.cloudera.org:8080/#/c/9140/3/be/src/exec/parquet-column-stats.cc@132 PS3, Line 132: const int64_t* ColumnStatsBase::ReadNullCountStat(const parquet::ColumnChunk& col_chunk) { > Sure, done. Why do we need to return a "const int64_t*" to the caller? Can't we just have the output argument be an int64_t* so that the this function writes the value to a caller-provided location? The caller just needs to get an int64_t value + an additional bit of information indicating whether it's valid or not. The NULL-ness of int64_t* pointer did encode that extra bit earlier, but I think it's best to avoid the memory lifetime concerns around returning pointers except when it's necessary. http://gerrit.cloudera.org:8080/#/c/9140/3/tests/query_test/test_parquet_stats.py File tests/query_test/test_parquet_stats.py: http://gerrit.cloudera.org:8080/#/c/9140/3/tests/query_test/test_parquet_stats.py@49 PS3, Line 49: self.client.execute('create table %s.table_for_null_count_test (i int, j int) ' > Sure. It was suggested by Anuj to move the create statements here. I'll mov Sorry for the churn. Why do you need to use $DATABASE though anyway? AFAIK run_test_case automatically switches to the use_db database so you should be fine dropping the $DATABASE. suffix. -- To view, visit http://gerrit.cloudera.org:8080/9140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I141317af0e0df30da8f220b29b0bfba364f40ddf Gerrit-Change-Number: 9140 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2018 21:46:40 +0000 Gerrit-HasComments: Yes
