Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 )
Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/9140/3/be/src/exec/parquet-column-stats.cc File be/src/exec/parquet-column-stats.cc: http://gerrit.cloudera.org:8080/#/c/9140/3/be/src/exec/parquet-column-stats.cc@132 PS3, Line 132: bool ColumnStatsBase::ReadNullCountStat(const parquet::ColumnChunk& col_chunk, > Why do we need to return a "const int64_t*" to the caller? Thanks Tim for the explanation. Makes sense. Done. http://gerrit.cloudera.org:8080/#/c/9140/3/tests/query_test/test_parquet_stats.py File tests/query_test/test_parquet_stats.py: http://gerrit.cloudera.org:8080/#/c/9140/3/tests/query_test/test_parquet_stats.py@49 PS3, Line 49: self.run_test_case('QueryTest/parquet-stats', vector, use_db=unique_database) > Sorry about the confusion. I thought that adding the create table statement Thanks Tim, Anuj! Dropped the $DATABASE prefix. -- To view, visit http://gerrit.cloudera.org:8080/9140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I141317af0e0df30da8f220b29b0bfba364f40ddf Gerrit-Change-Number: 9140 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Fri, 02 Feb 2018 09:20:17 +0000 Gerrit-HasComments: Yes
