Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 )
Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns ...................................................................... Patch Set 3: (4 comments) Thanks for taking a look, Zoli! http://gerrit.cloudera.org:8080/#/c/9140/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9140/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-6113 > it's IMPALA-6113 Nice, thx :) http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.h File be/src/exec/parquet-column-stats.h: http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.h@78 PS2, Line 78: returned > Currently it returns a pointer to a member of ColumnChunk. This means that In this case the ColumnChunk lives way longer than the code where I use the stats (ColumnChunk is part of the file_metadata_ in HDFSParquetScanner). I prefer writing a comment to note the future users of this function about this restriction. http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.cc File be/src/exec/parquet-column-stats.cc: http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.cc@132 PS2, Line 132: const int64_t* ColumnStatsBase::ReadNullCountStat(const parquet::ColumnChunk& col_chunk) { : if (!(col_chunk.__isset.meta_data && col_c > nit: can fit into one line Done http://gerrit.cloudera.org:8080/#/c/9140/2/be/src/exec/parquet-column-stats.cc@139 PS2, Line 139: } : : Sta > nit: can be a one-liner Done -- To view, visit http://gerrit.cloudera.org:8080/9140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I141317af0e0df30da8f220b29b0bfba364f40ddf Gerrit-Change-Number: 9140 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Jan 2018 14:53:50 +0000 Gerrit-HasComments: Yes
