Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 )
Change subject: IMPALA-6699: Fix Australian DST ending time ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG@7 PS1, Line 7: Fix Australian DST ending time Fix DST end time for Australian time-zones http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG@9 PS1, Line 9: Australian Daylight Saving Time "Australian Daylight Saving Time" is a misleading term as some Australian time-zones don't observe DST. Maybe you should enumerate the IDs of the time-zones affected by this change. http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG@10 PS1, Line 10: when it is set back when the clock is set back http://gerrit.cloudera.org:8080/#/c/9724/1/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: http://gerrit.cloudera.org:8080/#/c/9724/1/be/src/exprs/timezone_db.cc@399 PS1, Line 399: \"Australia/LHI\",\"LHST\",\"Lord Howe Standard Time\",\"LHDT\",\"Lord Howe Daylight Time\",\"+10:30:00\",\"+00:30:00\",\"1;0;10\",\"+02:00:00\",\"1;0;4\",\"+03:00:00\"\n\ Are you sure about LHDT? According to https://www.timeanddate.com/time/zones/lhdt LHDT ends 2018.04.01 02:00. http://gerrit.cloudera.org:8080/#/c/9724/1/testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test File testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test: http://gerrit.cloudera.org:8080/#/c/9724/1/testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test@17 PS1, Line 17: ---- QUERY : # IMPALA-6699: Australian DST should end at 3am (DST) and set back to 2am on the first : # Sunday of April. As a result timestamps between 2am and 3am that day are considered : # ambiguous. : SELECT : to_utc_timestamp("2018-04-01 01:59:59", "Australia/Melbourne"), : to_utc_timestamp("2018-04-01 02:00:00", "Australia/Melbourne"), : to_utc_timestamp("2018-04-01 02:59:59", "Australia/Melbourne"), : to_utc_timestamp("2018-04-01 03:00:00", "Australia/Melbourne"); : ---- TYPES : TIMESTAMP,TIMESTAMP,TIMESTAMP,TIMESTAMP : ---- RESULTS : 2018-03-31 14:59:59,NULL,NULL,2018-03-31 17:00:00 : ==== Could you move this test to expr-test.cc ? (similarly to IMPALA-4209/CDH-19918) -- To view, visit http://gerrit.cloudera.org:8080/9724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I461cd4a9057dfebfe8dd85b568cba4f1e87ad215 Gerrit-Change-Number: 9724 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 16:05:50 +0000 Gerrit-HasComments: Yes
