Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 )
Change subject: IMPALA-6699: Fix DST end time for Australian time zones ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9724/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9724/2//COMMIT_MSG@10 PS2, Line 10: the not necessary http://gerrit.cloudera.org:8080/#/c/9724/2//COMMIT_MSG@11 PS2, Line 11: This is a fix to adjust the exact ending : time to 3am on this day for all these time zones. Maybe something like this instead: The current timezone db contains the wrong DST end time. This fix sets the DST end time to 3am for all these timezones. http://gerrit.cloudera.org:8080/#/c/9724/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/9724/2/be/src/exprs/expr-test.cc@268 PS2, Line 268: Tests that the given timezone has it's DST ending at 3am Tests that DST of the given timezone ends at 3am http://gerrit.cloudera.org:8080/#/c/9724/2/be/src/exprs/expr-test.cc@5684 PS2, Line 5684: TestStringValue("cast(to_utc_timestamp('2018-04-01 02:00:00', '" + time_zone + "') " : "as string)", "NULL"); Please comment on why we expect NULL here and below -- To view, visit http://gerrit.cloudera.org:8080/9724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I461cd4a9057dfebfe8dd85b568cba4f1e87ad215 Gerrit-Change-Number: 9724 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 22 Mar 2018 14:47:21 +0000 Gerrit-HasComments: Yes
