Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 )
Change subject: IMPALA-6699: Fix Australian DST ending time ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG@9 PS1, Line 9: Australian Daylight Saving Time > "Australian Daylight Saving Time" is a misleading term as some Australian t There's a bad joke in Australia that Queensland is 1 hour and 20 years behind the rest of the east coast. http://gerrit.cloudera.org:8080/#/c/9724/1/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: http://gerrit.cloudera.org:8080/#/c/9724/1/be/src/exprs/timezone_db.cc@408 PS1, Line 408: \"Australia/Sydney\",\"AEST\",\"Australian Eastern Standard Time (New South Wales)\",\"AEDT\",\"Australian Eastern Daylight Time (New South Wales)\",\"+10:00:00\",\"+01:00:00\",\"1;0;10\",\"+02:00:00\",\"1;0;4\",\"+03:00:00\"\n\ Can we add tests for each of the time zones that were touched? Would be useful to have going forward. -- To view, visit http://gerrit.cloudera.org:8080/9724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I461cd4a9057dfebfe8dd85b568cba4f1e87ad215 Gerrit-Change-Number: 9724 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Mar 2018 19:12:35 +0000 Gerrit-HasComments: Yes
