Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 )
Change subject: IMPALA-6699: Fix DST end time for Australian time zones ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9724/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9724/2//COMMIT_MSG@10 PS2, Line 10: DST > not necessary Done http://gerrit.cloudera.org:8080/#/c/9724/2//COMMIT_MSG@11 PS2, Line 11: However, the current time zone DB contains : wrong DST end time for them. This fix sets the DS > Maybe something like this instead: Thanks for the suggestion. Rephrased a little bit. Done http://gerrit.cloudera.org:8080/#/c/9724/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/9724/2/be/src/exprs/expr-test.cc@268 PS2, Line 268: Tests that DST of the given timezone ends at 3am > Tests that DST of the given timezone ends at 3am Thanks for the suggestion. Done http://gerrit.cloudera.org:8080/#/c/9724/2/be/src/exprs/expr-test.cc@5684 PS2, Line 5684: // timestamp otherwise. : TestStringValue("cast(to_u > Please comment on why we expect NULL here and below Done -- To view, visit http://gerrit.cloudera.org:8080/9724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I461cd4a9057dfebfe8dd85b568cba4f1e87ad215 Gerrit-Change-Number: 9724 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 23 Mar 2018 11:53:49 +0000 Gerrit-HasComments: Yes
