Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 )
Change subject: IMPALA-6699: Fix DST end time for Australian time zones ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG@7 PS1, Line 7: Fix DST end time for Australia > Fix DST end time for Australian time-zones Done http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG@9 PS1, Line 9: In Australian time zones where > There's a bad joke in Australia that Queensland is 1 hour and 20 years behi Nice :) http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG@9 PS1, Line 9: In Australian time zones where > "Australian Daylight Saving Time" is a misleading term as some Australian t Rephrased the sentence a little bit. http://gerrit.cloudera.org:8080/#/c/9724/1//COMMIT_MSG@10 PS1, Line 10: ould end at 3am on > when the clock is set back Done http://gerrit.cloudera.org:8080/#/c/9724/1/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: http://gerrit.cloudera.org:8080/#/c/9724/1/be/src/exprs/timezone_db.cc@399 PS1, Line 399: \"Australia/LHI\",\"LHST\",\"Lord Howe Standard Time\",\"LHDT\",\"Lord Howe Daylight Time\",\"+10:30:00\",\"+00:30:00\",\"1;0;10\",\"+02:00:00\",\"1;0;4\",\"+02:00:00\"\n\ > Are you sure about LHDT? According to https://www.timeanddate.com/time/zon You are right with the LHDT. DST there starts at 2am to make it consistent :D http://gerrit.cloudera.org:8080/#/c/9724/1/be/src/exprs/timezone_db.cc@408 PS1, Line 408: \"Australia/Sydney\",\"AEST\",\"Australian Eastern Standard Time (New South Wales)\",\"AEDT\",\"Australian Eastern Daylight Time (New South Wales)\",\"+10:00:00\",\"+01:00:00\",\"1;0;10\",\"+02:00:00\",\"1;0;4\",\"+03:00:00\"\n\ > Can we add tests for each of the time zones that were touched? Would be use Sure, Done. http://gerrit.cloudera.org:8080/#/c/9724/1/testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test File testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test: http://gerrit.cloudera.org:8080/#/c/9724/1/testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test@17 PS1, Line 17: : : : : : : : : : : : : : > Could you move this test to expr-test.cc ? (similarly to IMPALA-4209/CDH-19 Done -- To view, visit http://gerrit.cloudera.org:8080/9724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I461cd4a9057dfebfe8dd85b568cba4f1e87ad215 Gerrit-Change-Number: 9724 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 08:07:19 +0000 Gerrit-HasComments: Yes
