Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 )
Change subject: Speed up Python dependencies. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py@172 PS2, Line 172: if results: > If the import above fails, then results = [] will never execute and this st Nice catch. We can get rid of the "if results:" line -- To view, visit http://gerrit.cloudera.org:8080/10234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30 Gerrit-Change-Number: 10234 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Fri, 27 Apr 2018 22:03:35 +0000 Gerrit-HasComments: Yes
