Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 )
Change subject: Speed up Python dependencies. ...................................................................... Patch Set 5: Code-Review+2 (3 comments) I impelemented your suggestions. I ran "buildall" long enough to get to the C++ compilation; verification to be done by GVO. http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py@141 PS4, Line 141: for line in open(requirements_file): > Nit: prefer open (https://docs.python.org/2/library/functions.html#file) Done http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py@150 PS4, Line 150: continue : pkg_name, pkg_version = l.split('==') : results.append(pool.apply_async( : download_packa > These four lines can be simplified as: Done http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py@154 PS4, Line 154: > Invert check and use continue to reduce nesting: Done -- To view, visit http://gerrit.cloudera.org:8080/10234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30 Gerrit-Change-Number: 10234 Gerrit-PatchSet: 5 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 18:22:43 +0000 Gerrit-HasComments: Yes
