Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 )
Change subject: Speed up Python dependencies. ...................................................................... Patch Set 4: Code-Review+2 (3 comments) I left a few nits that could reduce the code a bit, but I'm also good to limit this change to adding parallelism. Apologies for the incremental review. http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py@141 PS4, Line 141: for line in file(requirements_file): Nit: prefer open (https://docs.python.org/2/library/functions.html#file) http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py@150 PS4, Line 150: semi_colon_index = line.find(';') : if semi_colon_index != -1: : line = line[:semi_colon_index] : l = line.strip() These four lines can be simplified as: line.split(';')[0].strip() The same works for hash_index above. http://gerrit.cloudera.org:8080/#/c/10234/4/infra/python/deps/pip_download.py@154 PS4, Line 154: if len(l) > 0: Invert check and use continue to reduce nesting: if not line: continue -- To view, visit http://gerrit.cloudera.org:8080/10234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30 Gerrit-Change-Number: 10234 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 04:21:29 +0000 Gerrit-HasComments: Yes
