Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 )
Change subject: Speed up Python dependencies. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10234/3/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: http://gerrit.cloudera.org:8080/#/c/10234/3/infra/python/deps/pip_download.py@140 PS3, Line 140: f = open(requirements_file, 'r') While you are making changes here, you could actually change this to "for line in open(...):", which takes care of closing the file, even if it hits an exception. http://gerrit.cloudera.org:8080/#/c/10234/3/infra/python/deps/pip_download.py@158 PS3, Line 158: if pool: This check seems unnecessary now -- To view, visit http://gerrit.cloudera.org:8080/10234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30 Gerrit-Change-Number: 10234 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 03:53:09 +0000 Gerrit-HasComments: Yes
