Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10440 )

Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify 
state
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

http://gerrit.cloudera.org:8080/#/c/10440/1/be/src/runtime/coordinator.cc@693
PS1, Line 693:       // We may start receiving status reports before all exec 
rpcs are complete.
             :       // Can't apply state transition until no more exec rpcs 
will be sent.
             :       exec_rpcs_complete_barrier_->Wait();
> Just to make sure I understand the bug correctly, we only need to wait for
For the bug we were hitting. But we also need to wait for all exec rpcs to 
avoid the case of the cancel rpc passing the exec rpc for the other backends 
(the new comment in HandleExecStateTransition is meant to explain that - lmk if 
it needs clarification).

I think what we'll want to do is preserve this barrier, but be able to skip 
sending exec rpcs when there is an error to unblock this barrier sooner.



--
To view, visit http://gerrit.cloudera.org:8080/10440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dc08da1295f1df3c9dce6d35d65d887b2c00a1c
Gerrit-Change-Number: 10440
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 May 2018 19:16:18 +0000
Gerrit-HasComments: Yes

Reply via email to