Hello Tim Armstrong, Bikramjeet Vig,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10440
to look at the new patch set (#2).
Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify
state
......................................................................
IMPALA-5384, part 2: Simplify Coordinator locking and clarify state
The is the final change to clarify and break up the Coordinator's lock.
The state machine for the coordinator is made explicit, distinguishing
between executing state and multiple terminal states. Logic to
transition into a terminal state is centralized in one location and
executes exactly once for each coordinator object.
Derived from a patch for IMPALA_5384 by Marcel Kornacker.
Testing:
- exhaustive functional tests
- stress test on minicluster with memory overcommitment. Verified from
the logs that this exercises all these paths:
- successful queries
- client requested cancellation
- error from exec FInstances RPC
- error reported asynchronously via report status RPC
- eos before backend execution completed
- loop query_test & failure for 12 hours with no dchecks or crashes
(This had previously reproduced IMPALA-7030 and IMPALA-7033 with
the previous version of this change).
Change-Id: I6dc08da1295f1df3c9dce6d35d65d887b2c00a1c
---
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/client-request-state.cc
M be/src/service/impala-server.h
M be/src/util/counting-barrier.h
6 files changed, 396 insertions(+), 391 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/10440/2
--
To view, visit http://gerrit.cloudera.org:8080/10440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6dc08da1295f1df3c9dce6d35d65d887b2c00a1c
Gerrit-Change-Number: 10440
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
