Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22191
Change subject: IMPALA-13597: Use the Python3 venv module for critique-gerrit-review.py ...................................................................... IMPALA-13597: Use the Python3 venv module for critique-gerrit-review.py Commit 8e71f5ec8609cc046cf35eb044d91bf34ae9f9c7 has changed the Python environment for the gerrit-auto-critic script from Python2 to Python3. Unfortunately the change has not updated the virtualenv module used within the auto-critic script, so the script started failing. This patch changes the virtualenv implementation used for this script to the venv module offered by default in Python3, and bumps the flak8 modules used to newer versions. Additionally it fixes a regex search string in test_kudu.py (changes the regex pattern string to a raw Python string), which caused a strange, unattributed warning message from flake8. The python3-venv package was installed manually on jenkins.impala.io during testing. Tests: - ran the new script locally - ran the new script through the precommit process Change-Id: I5efa035fae38bd42cc3b07f479da2b3983f68252 --- M bin/jenkins/critique-gerrit-review.py M tests/query_test/test_kudu.py 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/22191/1 -- To view, visit http://gerrit.cloudera.org:8080/22191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5efa035fae38bd42cc3b07f479da2b3983f68252 Gerrit-Change-Number: 22191 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]>
