Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22191 )
Change subject: IMPALA-13597: Use the Python3 venv module for critique-gerrit-review.py ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Thank you Laszlo for taking care of this. http://gerrit.cloudera.org:8080/#/c/22191/1/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22191/1/bin/jenkins/critique-gerrit-review.py@48 PS1, Line 48: : FLAKE8_VERSION = "7.1.1" I assume, this is independent from the other flake8 version we have? https://github.com/apache/impala/blob/79eb48e9f63a87bf240080949c11e90b47c1367f/bin/impala-flake8#L21 https://github.com/apache/impala/blob/79eb48e9f63a87bf240080949c11e90b47c1367f/infra/python/deps/py2-requirements.txt#L23 -- To view, visit http://gerrit.cloudera.org:8080/22191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5efa035fae38bd42cc3b07f479da2b3983f68252 Gerrit-Change-Number: 22191 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2024 15:31:53 +0000 Gerrit-HasComments: Yes
