Hello Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22191
to look at the new patch set (#2).
Change subject: IMPALA-13597: Use the Python3 venv module for
critique-gerrit-review.py
......................................................................
IMPALA-13597: Use the Python3 venv module for critique-gerrit-review.py
Commit 8e71f5ec8609cc046cf35eb044d91bf34ae9f9c7 has changed the Python
environment for the gerrit-auto-critic script from Python2 to Python3.
Unfortunately the change has not updated the virtualenv module used
within the auto-critic script, so the script started failing.
This patch changes the virtualenv implementation used for this script
to the venv module offered by default in Python3, and bumps the flake8
module to a newer version. Stdout stream handling is also switched to
text mode for Popen.
The patch also fixes a regex search string in test_kudu.py (changes the
regex pattern string to a raw Python string). This is somewhat unrelated
to the Python script change, but it was discovered during testing to
make flake8 emit a badly formatted warning message.
The python3-venv package was installed manually on jenkins.impala.io
during testing.
Tests:
- ran the new script locally
- ran the new script through the precommit process
Change-Id: I5efa035fae38bd42cc3b07f479da2b3983f68252
---
M bin/jenkins/critique-gerrit-review.py
M tests/query_test/test_kudu.py
2 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/22191/2
--
To view, visit http://gerrit.cloudera.org:8080/22191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5efa035fae38bd42cc3b07f479da2b3983f68252
Gerrit-Change-Number: 22191
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
