Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22191 )

Change subject: IMPALA-13597: Use the Python3 venv module for 
critique-gerrit-review.py
......................................................................


Patch Set 3: Verified+1 Code-Review+2

This does seem to fix it:
* successful run in https://jenkins.impala.io/job/test-gerrit-auto-critic/3/
* I manually verified test_kudu.py::TestKuduPartitioning still works.

Just checking with Laszlo whether he wants to incorporate more patches from 
https://github.com/gaallas/Impala/commits/fix-gerrit-critique/ before we merge.


--
To view, visit http://gerrit.cloudera.org:8080/22191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5efa035fae38bd42cc3b07f479da2b3983f68252
Gerrit-Change-Number: 22191
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 10 Dec 2024 17:39:37 +0000
Gerrit-HasComments: No

Reply via email to