Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22191 )
Change subject: IMPALA-13597: Use the Python3 venv module for critique-gerrit-review.py ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22191/1/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22191/1/bin/jenkins/critique-gerrit-review.py@48 PS1, Line 48: : FLAKE8_VERSION = "7.1.1" > I assume, this is independent from the other flake8 version we have? Great catch, and yes, these are independent of each other (although it makes sense that the versions were in synch). This script runs on jenkins.impala.io in a self-installed minimal venv, now with Python3; the above entries use flake8 inside Impala's own virtualenv, with the flake version pinned for the Python2-based version of it. -- To view, visit http://gerrit.cloudera.org:8080/22191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5efa035fae38bd42cc3b07f479da2b3983f68252 Gerrit-Change-Number: 22191 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2024 16:19:42 +0000 Gerrit-HasComments: Yes
