Riza Suminto has posted comments on this change. (
http://gerrit.cloudera.org:8080/22191 )
Change subject: IMPALA-13597: Upgrade critique-gerrit-review.py to Python3
......................................................................
Patch Set 4: Code-Review+1
Looks good. This is what it looks like in my machine:
$ rm -r gerrit_critic_venv
$ ./bin/jenkins/critique-gerrit-review.py --dryrun
Requirement already satisfied: wheel in /usr/lib/python3/dist-packages (0.34.2)
Collecting flake8==7.1.1
Using cached flake8-7.1.1-py2.py3-none-any.whl (57 kB)
Processing
/home/rsuminto/.cache/pip/wheels/d1/a9/a9/cc03c41c768c6e2f7b2a995d6814c49880b8aacafb70a53d7c/flake8_diff-0.2.2-py3-none-any.whl
Collecting pyflakes<3.3.0,>=3.2.0
Using cached pyflakes-3.2.0-py2.py3-none-any.whl (62 kB)
Collecting pycodestyle<2.13.0,>=2.12.0
Using cached pycodestyle-2.12.1-py2.py3-none-any.whl (31 kB)
Collecting mccabe<0.8.0,>=0.7.0
Using cached mccabe-0.7.0-py2.py3-none-any.whl (7.3 kB)
Requirement already satisfied: six in /usr/lib/python3/dist-packages (from
flake8-diff==0.2.2) (1.14.0)
Collecting argparse
Using cached argparse-1.4.0-py2.py3-none-any.whl (23 kB)
Collecting blessings
Using cached blessings-1.7-py3-none-any.whl (18 kB)
Installing collected packages: pyflakes, pycodestyle, mccabe, flake8, argparse,
blessings, flake8-diff
Successfully installed argparse-1.4.0 blessings-1.7 flake8-7.1.1
flake8-diff-0.2.2 mccabe-0.7.0 pycodestyle-2.12.1 pyflakes-3.2.0
Updated 0 paths from the index
{
"comments": {}
}
Can +2 if Michael has no more comments.
--
To view, visit http://gerrit.cloudera.org:8080/22191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5efa035fae38bd42cc3b07f479da2b3983f68252
Gerrit-Change-Number: 22191
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 10 Dec 2024 18:14:45 +0000
Gerrit-HasComments: No
