Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22201 )
Change subject: IMPALA-13600: Fix Flaky JWT Test ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@206 PS3, Line 206: def __assert_success_fail_metric(self, impalad_service, success_count=0, fail_count=0): > Now that the function signature has less argument, it is probably worth to There is not a case where the JWT authentications partially succeed and partially fail. Thus, in all instances where this function is called, only 1 of 'success_count' or 'fail_count' is specified. I like having the default of zero which encourages callers to use named parameters making it much clearer if the test is expecting successes or failures. -- To view, visit http://gerrit.cloudera.org:8080/22201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eebd74e1ce10ad24055b7fab4b1901ce61e03 Gerrit-Change-Number: 22201 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 16:25:33 +0000 Gerrit-HasComments: Yes
