Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22201 )
Change subject: IMPALA-13600: Fix Flaky JWT Test ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@80 PS3, Line 80: 15 nit: timeout=15 http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@206 PS3, Line 206: def __assert_success_fail_metric(self, impalad_service, success_count=0, fail_count=0): > Before, when the code was asserting that the success/fail metric fell withi Ack http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@208 PS3, Line 208: This function asserts the JWT auth success/fail counters from the : coordinator match the expected values.""" "This function asserts the JWT auth success and fail counters from the coordinator are exactly equal to success_count and fail_count respectively." http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@212 PS3, Line 212: 1 nit: timeout=1 http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@215 PS3, Line 215: 1 nit: timeout=1 -- To view, visit http://gerrit.cloudera.org:8080/22201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eebd74e1ce10ad24055b7fab4b1901ce61e03 Gerrit-Change-Number: 22201 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 17:20:04 +0000 Gerrit-HasComments: Yes
