Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22201 )
Change subject: IMPALA-13600: Fix Flaky JWT Test ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@73 PS3, Line 73: impala.thrift-server.hiveserver2-http-frontend.total-connections > Long metric names could be constants Done http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@80 PS3, Line 80: 15 > nit: timeout=15 Done http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@208 PS3, Line 208: This function asserts the JWT auth success/fail counters from the : coordinator are within the specified ranges. > Please disregard. I was looking at older patchset. Done http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@212 PS3, Line 212: 1 > nit: timeout=1 Done http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@215 PS3, Line 215: 1 > nit: timeout=1 Done http://gerrit.cloudera.org:8080/#/c/22201/4/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22201/4/tests/custom_cluster/test_shell_jwt_auth.py@210 PS4, Line 210: impalad_service.wait_for_metric_value > This can just be impalad.get_metric_value ? Done -- To view, visit http://gerrit.cloudera.org:8080/22201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eebd74e1ce10ad24055b7fab4b1901ce61e03 Gerrit-Change-Number: 22201 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 17:31:43 +0000 Gerrit-HasComments: Yes
