Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22201 )
Change subject: IMPALA-13600: Fix Flaky JWT Test ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22201/3/tests/custom_cluster/test_shell_jwt_auth.py@206 PS3, Line 206: def __assert_success_fail_metric(self, impalad_service, success_count=0, fail_count=0): > So why this is not written as two separate function, __assert_success_metri Before, when the code was asserting that the success/fail metric fell within a range, it was necessary to check the opposing metric had a value of 0 in case a small enough number of JWT authentications did not go as expected. For example, if the successful JWT authentications could be between 15 and 16, then 15 auths could succeed with the 16th failing. In that situation, the successful JWT auths assertion would pass, thus it was necessary to also check that the count of failed JWT auths was 0. Now, since the tests use an Impala metric to determine the expected number of succeeded/failed JWT auths, checking the opposing metric is not critical. Still, it is a good check to do just in case. Thus, I want to keep both metrics in the same function so both metrics are automatically checked with a single function call. -- To view, visit http://gerrit.cloudera.org:8080/22201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eebd74e1ce10ad24055b7fab4b1901ce61e03 Gerrit-Change-Number: 22201 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 17:00:49 +0000 Gerrit-HasComments: Yes
