Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22201 )
Change subject: IMPALA-13600: Fix Flaky JWT Test ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/22201/6/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22201/6/tests/custom_cluster/test_shell_jwt_auth.py@24 PS6, Line 24: from time import sleep this can be removed? http://gerrit.cloudera.org:8080/#/c/22201/6/tests/custom_cluster/test_shell_jwt_auth.py@198 PS6, Line 198: self.cluster.get_first_impalad().service.wait_for_metric_value( : "impala.thrift-server.hiveserver2-http-frontend.total-jwt-token-auth-success", : success_count, timeout=1) : self.cluster.get_first_impalad().service.wait_for_metric_value( : "impala.thrift-server.hiveserver2-http-frontend.total-jwt-token-auth-failure", : fail_count, timeout=1) Actually, there is get_metric_values function so you can get both from single JSON metrics. -- To view, visit http://gerrit.cloudera.org:8080/22201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0eebd74e1ce10ad24055b7fab4b1901ce61e03 Gerrit-Change-Number: 22201 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 17:37:27 +0000 Gerrit-HasComments: Yes
