Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22322 )
Change subject: IMPALA-13658: Enable tuple caching aggregates ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Looks good. Tested with tpc queries with correctness verification on, no issues found. http://gerrit.cloudera.org:8080/#/c/22322/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22322/2//COMMIT_MSG@12 PS2, Line 12: Could we also mention the new added test cases in the testing section? http://gerrit.cloudera.org:8080/#/c/22322/2/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/22322/2/tests/custom_cluster/test_tuple_cache.py@382 PS2, Line 382: assert bytes_written[0] == bytes_read[0] Would it be good to add two more simple cases after the previous two queries: "select avg(int_col) from functional.alltypes;" and "select avg(a) from (select sum(int_col) as a from functional.alltypes) b;"? The first case would test loading the cache from the scan node, while the second case would test loading the cache from the sum agg node with a slightly different query. -- To view, visit http://gerrit.cloudera.org:8080/22322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bd13c2813c90d23eb3a70f98068fdcdab97a885 Gerrit-Change-Number: 22322 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:04:37 +0000 Gerrit-HasComments: Yes
