Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22322 )
Change subject: IMPALA-13658: Enable tuple caching aggregates ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22322/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22322/2//COMMIT_MSG@12 PS2, Line 12: > Could we also mention the new added test cases in the testing section? Done http://gerrit.cloudera.org:8080/#/c/22322/2/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/22322/2/tests/custom_cluster/test_tuple_cache.py@382 PS2, Line 382: bytes_read = getCounterValues(result2.runtime_profile, "TupleCacheBytesRead") > Would it be good to add two more simple cases after the previous two querie Done -- To view, visit http://gerrit.cloudera.org:8080/22322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bd13c2813c90d23eb3a70f98068fdcdab97a885 Gerrit-Change-Number: 22322 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 19:57:59 +0000 Gerrit-HasComments: Yes
