Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22362 )
Change subject: IMPALA-13682: Implement missing capabilities in ImpylaHS2Client ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/22362/7/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22362/7/tests/custom_cluster/test_admission_controller.py@526 PS7, Line 526: vector I understand that passing 'vector' and calling create_impala_client_from_vector() everywhere maybe impractical. I'm thinking of adding a new fixture 'iclient' that can simplify this: @pytest.yield_fixture def iclient(request, vector): """ Provides a new Impala client as a pytest fixture. The client only exists for the duration of the method it is used in. Require 'vector' fixture as input. """ client = request.cls.create_impala_client_from_vector(vector) try: yield client finally: try: client.close() except Exception as e: LOG.warn("Error closing Impala connection: %s", e) -- To view, visit http://gerrit.cloudera.org:8080/22362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac07732424c16338e060c9392100b54337f11b8 Gerrit-Change-Number: 22362 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 00:37:08 +0000 Gerrit-HasComments: Yes
