Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22362 )
Change subject: IMPALA-13682: Implement missing capabilities in ImpylaHS2Client ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/22362/7/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22362/7/tests/common/impala_connection.py@581 PS7, Line 581: cursor_count, self.get_test_protocol(), self.__host_port)) > This log message could potentially be confusing. It would be clearer to lo Ack. Will address in next patch set. http://gerrit.cloudera.org:8080/#/c/22362/7/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22362/7/tests/custom_cluster/test_admission_controller.py@519 PS7, Line 519: client.close() > Can the new syntax be used here? Just want to reduce the diff size. But this might change in next patch set. http://gerrit.cloudera.org:8080/#/c/22362/7/tests/custom_cluster/test_admission_controller.py@526 PS7, Line 526: vector > I understand that passing 'vector' and calling create_impala_client_from_ve That being said, we might be able to keep using self.client directly for now as long as default_test_protocol(cls): return 'hs2'. Let me rebase this patch and investigate it. http://gerrit.cloudera.org:8080/#/c/22362/7/tests/custom_cluster/test_admission_controller.py@544 PS7, Line 544: my_client.close() > Why not use the new syntax? Also applicable to the rest of the tests that Just want to reduce the diff size. But this might change in next patch set. -- To view, visit http://gerrit.cloudera.org:8080/22362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac07732424c16338e060c9392100b54337f11b8 Gerrit-Change-Number: 22362 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 17:27:11 +0000 Gerrit-HasComments: Yes
