Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22599 )
Change subject: IMPALA-13795: Support serving webUI content with gzip compression ...................................................................... Patch Set 2: (5 comments) I have added the tests now, also plain responses without content-encoding are provided as before in case of failure. Thank you for the comments. http://gerrit.cloudera.org:8080/#/c/22599/1//COMMIT_MSG Commit Message: PS1: > Does it make sense to add an automated test to verify that the server sends Done http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/compress.h File be/src/util/compress.h: http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/compress.h@66 PS1, Line 66: int compression_level_ > nit: could this be 'const'? It would be better to let compression_level_ be modifiable, as it is already private. On L155 also for ZSTD, probably it was kept that way for similar reasons. http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/compress.cc File be/src/util/compress.cc: http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/compress.cc@49 PS1, Line 49: DCHECK_IN_RANGE(compression_level, -1, 9); > nit: consider adding DCHECK() for compression_level; I guess it should be b Done http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/webserver.cc@257 PS1, Line 257: uint8_t* compressed_ > Is it possible to call this even if compressor->ProcessBlock() above fails? Done http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/webserver.cc@293 PS1, Line 293: oss << "Content-Length: " << output.si > What happens if this fails? Will the result content be sent corrupted? Ma Done -- To view, visit http://gerrit.cloudera.org:8080/22599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431088a30337bbef2c8d6e16dd15fb6572db0f15 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 18 Mar 2025 13:31:04 +0000 Gerrit-HasComments: Yes
