Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@949 PS5, Line 949: toSqlString(); > I think this method name is confusing. I think we should rename this. Any s The more I think about it, I don't think it's easy to figure out if the expr has been rewritten if not from the call-site. Calling reset() is one way of determining if an expr is rewritten, but it is also possible to clone() the expr so the reset() never gets called and it'll be hard to figure out if the expr is rewritten. I'm also a bit hesitant of adding another state since we already have so many states and we also need to figure out whether or not to clear the state in the reset(). -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 21:43:09 +0000 Gerrit-HasComments: Yes
