Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled ...................................................................... Patch Set 5: (1 comment) thanks for the change. this will be a useful step to make it easier to debug/make sense of errors after the rewrite phase. main comment is about guarantees for the new method. http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@949 PS5, Line 949: toSqlString(); how do we know that the expression has been rewritten? you're controlling this from one specific call-site, but I'd prefer that this expr know whether its been rewritten and whether this method makes sense to call. same goes for the other impls. we know that the expr is analyzed-- that's a start. is additional state needed to record if rewritten? -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 21:02:44 +0000 Gerrit-HasComments: Yes
