Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@949 PS5, Line 949: toSqlString(); > how do we know that the expression has been rewritten? you're controlling t I think this method name is confusing. I think we should rename this. Any suggestion on the name? It's basically a toSql() that doesn't use any SQL string that was previously stored. -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 21:07:14 +0000 Gerrit-HasComments: Yes
