Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24270 )
Change subject: IMPALA-14937: (part 2) Enable MERGE for Iceberg V3 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java: http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@117 PS1, Line 117: if (formatVersion > 3) { Optional: Potentially put "3" as a constant static VERSION variable to be used here and other places? Not sure that helps too much, but when version 4 comes out, we'll be able to find the code specific to version 3 a little easier? Keeping this as optional, not sure this is a big deal. http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java: http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java@84 PS1, Line 84: buildRowLineage(targetTableRef, analyzer, targetExpressions, rowMetaExpressions); Optional: Is this the only place buildRowLineage is called? If so, I have two comments: 1) As a developer, I never like passing in mutated parameters. This situation isn't too egregious since it only goes one level deep and the method name has "build" in it. But I still like avoiding this as a paradigm. I find it much easier to debug when the variables are right in front of me being populated and not filled in because of a method call. But also, since there are only 3 statements in the build method, I would get rid of the method and just put the 3 statements here. 2) If you do decide to keep the method and it's the only place it's called, should we make it "private"? -- To view, visit http://gerrit.cloudera.org:8080/24270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5813d293c35cb084bda89aa0cf6df5cb420d2ea Gerrit-Change-Number: 24270 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 05 May 2026 15:07:07 +0000 Gerrit-HasComments: Yes
