Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24270 )
Change subject: IMPALA-14937: (part 2) Enable MERGE for Iceberg V3 ...................................................................... Patch Set 2: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24270/2/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java: http://gerrit.cloudera.org:8080/#/c/24270/2/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@124 PS2, Line 124: if (formatVersion >= IcebergUtil.FORMAT_VERSION_3 && !mergeStmt_.hasOnlyInsertCases()) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24270/2/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java: http://gerrit.cloudera.org:8080/#/c/24270/2/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java@78 PS2, Line 78: if (icebergTable.getFormatVersion() >= IcebergUtil.FORMAT_VERSION_3 && mergeStmt.hasUpdateCase()) { line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/24270/2/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java@90 PS2, Line 90: targetTableRef.getUniqueAlias(), VirtualColumn.ICEBERG_FIRST_ROW_ID.getName()))); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5813d293c35cb084bda89aa0cf6df5cb420d2ea Gerrit-Change-Number: 24270 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2026 17:00:49 +0000 Gerrit-HasComments: Yes
