Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24270 )
Change subject: IMPALA-14937: (part 2) Enable MERGE for Iceberg V3 ...................................................................... Patch Set 2: (7 comments) Thanks Steve and Zoltan! http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java: http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@117 PS1, Line 117: IcebergUtil.validateIcebergTableForInsert(icebergTable_); > Optional: Potentially put "3" as a constant static VERSION variable to be u Done http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@236 PS1, Line 236: > How newly inserted records getting shuffled? If there are many new records Done http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@256 PS1, Line 256: umns so each sink instance sees > We should precondition check that it's INPUT__FILE__NAME. Done http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java: http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java@80 PS1, Line 80: . > You could mention that the ordering has to be fixed for the backend Merge o Done http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java@84 PS1, Line 84: } > Optional: Is this the only place buildRowLineage is called? If so, I have t I went with inlining the method. http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java@118 PS1, Line 118: essions > record / data file? I removed this comment as it sounds odd here. http://gerrit.cloudera.org:8080/#/c/24270/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24270/1/tests/query_test/test_iceberg.py@2534 PS1, Line 2534: V2 then upgraded to V3 > All tables in the test file are created as V3. Added a V2-V3 migration case. -- To view, visit http://gerrit.cloudera.org:8080/24270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5813d293c35cb084bda89aa0cf6df5cb420d2ea Gerrit-Change-Number: 24270 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2026 16:59:15 +0000 Gerrit-HasComments: Yes
