Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24270 )
Change subject: IMPALA-14937: (part 2) Enable MERGE for Iceberg V3 ...................................................................... Patch Set 1: (5 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java: http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@236 PS1, Line 236: raw partition metadata (PARTITION__SPEC__ID, ICEBERG__PARTITION__SERIALIZED) How newly inserted records getting shuffled? If there are many new records (with no part spec id, nor partition__serialized fields), then they are probably routed to the same executor. Maybe we should come up with an expression with COALESCE / CASE? http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@256 PS1, Line 256: targetRowMetaExpressions_.get(0) We should precondition check that it's INPUT__FILE__NAME. http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java: http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java@80 PS1, Line 80: . You could mention that the ordering has to be fixed for the backend Merge operator. http://gerrit.cloudera.org:8080/#/c/24270/1/fe/src/main/java/org/apache/impala/analysis/IcebergMergeQueryGenerator.java@118 PS1, Line 118: backend record / data file? http://gerrit.cloudera.org:8080/#/c/24270/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24270/1/tests/query_test/test_iceberg.py@2534 PS1, Line 2534: V2 then upgraded to V3 All tables in the test file are created as V3. -- To view, visit http://gerrit.cloudera.org:8080/24270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5813d293c35cb084bda89aa0cf6df5cb420d2ea Gerrit-Change-Number: 24270 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 14:01:07 +0000 Gerrit-HasComments: Yes
