Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24270 )
Change subject: IMPALA-14937: (part 2) Enable MERGE for Iceberg V3 ...................................................................... Patch Set 3: Code-Review+1 (2 comments) LGTM! http://gerrit.cloudera.org:8080/#/c/24270/3/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java: http://gerrit.cloudera.org:8080/#/c/24270/3/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@282 PS3, Line 282: return Collections.singletonList(DmlStatementBase.createSlotRef( : analyzer, targetTableRef_.getUniqueAlias(), "INPUT__FILE__NAME")); This is not needed (and better to avoid) for INSERT-only MERGE statements. http://gerrit.cloudera.org:8080/#/c/24270/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-merge.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-merge.test: http://gerrit.cloudera.org:8080/#/c/24270/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-merge.test@427 PS3, Line 427: Verifies that each data file is referenced by at most one deletion : # vector. The data files don't have multiple blocks so it's hard to verify based on the results only. But we could have a ----RUNTIME_PROFILE section, under which we could verify that the plan has shuffle based on INPUT__FILE__NAME. In a few partitioned cases we could verify the COALESCE(...) expr in the plan this way. -- To view, visit http://gerrit.cloudera.org:8080/24270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5813d293c35cb084bda89aa0cf6df5cb420d2ea Gerrit-Change-Number: 24270 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 11 May 2026 15:17:50 +0000 Gerrit-HasComments: Yes
