Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24261 )
Change subject: IMPALA-14849: Upgrade Calcite planner to 1.42 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24261/3/tests/query_test/test_spilling.py File tests/query_test/test_spilling.py: http://gerrit.cloudera.org:8080/#/c/24261/3/tests/query_test/test_spilling.py@115 PS3, Line 115: @SkipIfCalcite.spilling_plan_different > Maybe we could loop in Stamatis Zampetakis for his input? I did talk offline to Stamatis on this one. I think we're gonna leave this alone for now and deal with this as a separate Jira. The common consensus was that it was better to have a query that works slowly rather versus throwing an error exception. I will file a Jira for this when this is ready for commit and change the message. -- To view, visit http://gerrit.cloudera.org:8080/24261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8 Gerrit-Change-Number: 24261 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 17:25:49 +0000 Gerrit-HasComments: Yes
