Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24261 )
Change subject: IMPALA-14849: Upgrade Calcite planner to 1.42 ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24261/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24261/4//COMMIT_MSG@19 PS4, Line 19: Some problems addressed: In IMPALA-14849, you had said "There is some code in RexCallConverter.java that can be removed when the upgrade is done, which was fixed with CALCITE-7287. " However, this file is not modified in this patch. Did you want to include those changes ? http://gerrit.cloudera.org:8080/#/c/24261/4/testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test File testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test: http://gerrit.cloudera.org:8080/#/c/24261/4/testdata/workloads/functional-query/queries/QueryTest/calcite_subquery.test@125 PS4, Line 125: ---- RESULTS Since the subquery has a LIMIT without order-by, it is possible it could produce different results in different executions. i.e it produces **any** 5 rows as long as b.id = a.id, so if there are > 5 matching rows, the results could be different and make this a flaky test. Do you know if the original error had something to do with the presence of LIMIT in the subquery ? -- To view, visit http://gerrit.cloudera.org:8080/24261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8 Gerrit-Change-Number: 24261 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 22:49:34 +0000 Gerrit-HasComments: Yes
