Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24733 )
Change subject: IMPALA-14996: Optimize count(*) for Iceberg V3 DV-only tables ...................................................................... Patch Set 2: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24733/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/24733/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@36 PS1, Line 36: import org.apache.impala.analysis.Path.PathType; > unused import: org.apache.iceberg.Table Done http://gerrit.cloudera.org:8080/#/c/24733/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24733/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@1237 PS1, Line 1237: if (dataRecords < 0) return -1; > You can combine the two iterations (fileStore.getDataFilesWithoutDeletes an Thanks for the suggestion! We can use getRecordCountV1() to get the record count without iterations. http://gerrit.cloudera.org:8080/#/c/24733/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@1243 PS1, Line 1243: if (!dv.isSetRecord_count()) return -1; > nit: Here we iterate through the getDataFileToDV twice (first over the valu Since, iterations for data records are now removed, we dont have repetitive iterations anymore. -- To view, visit http://gerrit.cloudera.org:8080/24733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e6239629ee779a64808a0a4bbe041ef756c5bb2 Gerrit-Change-Number: 24733 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2026 08:57:08 +0000 Gerrit-HasComments: Yes
