Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24733 )
Change subject: IMPALA-14996: Optimize count(*) for Iceberg V3 DV-only tables ...................................................................... Patch Set 3: (2 comments) Thanks for suggesting the optimizations! http://gerrit.cloudera.org:8080/#/c/24733/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24733/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@1214 PS2, Line 1214: if (travelSpec == null) { > I think we can avoid decoding these lists from flatbuffer, if we add a new Great suggestion, we are following IcebergContentFileStore.hasDeletes() pattern now. Small correction, we have to use &&. We can use few more early exit branches to prevent iterating through the manifests like: 1. total-delete-files == 0 2. total-equality-deletes > 0 3. total-position-deletes == 0 All three would return false. http://gerrit.cloudera.org:8080/#/c/24733/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@1239 PS2, Line 1239: return groupedFiles.positionDeleteFiles.isEmpty() > I think we can possibly answer this from the snapshot summary too: https:// Yes, we can use it safely for DV only files. We are following similar pattern as getRecordCountV1() to get the position deletes from the snapshot summry. -- To view, visit http://gerrit.cloudera.org:8080/24733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e6239629ee779a64808a0a4bbe041ef756c5bb2 Gerrit-Change-Number: 24733 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2026 07:24:27 +0000 Gerrit-HasComments: Yes
