Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24733 )
Change subject: IMPALA-14996: Optimize count(*) for Iceberg V3 DV-only tables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24733/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24733/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@1214 PS2, Line 1214: return fileStore.getPositionDeleteFiles().isEmpty() I think we can avoid decoding these lists from flatbuffer, if we add a new method to IcebergContentFileStore. Something like this: public boolean hasOnlyDeleteVectors() { return positionDeleteFiles_.fileDescList_.isEmpty() || equalityDeleteFiles_.fileDescList_.isEmpty() || !dataFileToDV_.isEmpty(); } -- To view, visit http://gerrit.cloudera.org:8080/24733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e6239629ee779a64808a0a4bbe041ef756c5bb2 Gerrit-Change-Number: 24733 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 13:13:30 +0000 Gerrit-HasComments: Yes
