Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24733 )
Change subject: IMPALA-14996: Optimize count(*) for Iceberg V3 DV-only tables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24733/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24733/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@1239 PS2, Line 1239: if (travelSpec == null) { I think we can possibly answer this from the snapshot summary too: https://iceberg.apache.org/spec/#metrics I think the record sum, that we got here while we iterate through each delete vector should be the same as 'total-position-deletes', which in case of DV only files, should be safe to use no? -- To view, visit http://gerrit.cloudera.org:8080/24733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e6239629ee779a64808a0a4bbe041ef756c5bb2 Gerrit-Change-Number: 24733 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 11:38:04 +0000 Gerrit-HasComments: Yes
