Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/24590 )
Change subject: IMPALA-9821: Change DataSketches functions to return BINARY ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/24590/6/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test: http://gerrit.cloudera.org:8080/#/c/24590/6/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test@16 PS6, Line 16: .) > This will exercise the original "write as BINARY in Hive, read as STRING in > Impala" path. You propose to add such a test? Could you pls clarify an exact action item you have in mind if any (except the ones for .test file threads). http://gerrit.cloudera.org:8080/#/c/24590/10/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test: http://gerrit.cloudera.org:8080/#/c/24590/10/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test@14 PS10, Line 14: BINARY column as STRING > I wouldn't refer to IMPALA-9482 as ORC fix, as it is the epic for the whole Done, hope it clarifies things. http://gerrit.cloudera.org:8080/#/c/24590/10/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test@29 PS10, Line 29: rc > Why not check the exact type and do the same with Hive? This would show tha Done. I used different field now though to have some meaningful NDV values. 'ds_hll_estimate' returns DOUBLE in Hive so the cast to BIGINT is needed to absorb HLL's floating-point approximation. -- To view, visit http://gerrit.cloudera.org:8080/24590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 Gerrit-Change-Number: 24590 Gerrit-PatchSet: 11 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2026 08:34:27 +0000 Gerrit-HasComments: Yes
