Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24590 )
Change subject: IMPALA-9821: Change DataSketches functions to return BINARY ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/24590/6/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test: http://gerrit.cloudera.org:8080/#/c/24590/6/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test@16 PS6, Line 16: .) > > This will exercise the original "write as BINARY in Hive, read as STRING If you want to test scenario that originally could cause the type mismatch error message mentioned, then yes, you should add an ALTER TABLE after inserting to rows in Hive to create a STRING column from this. Either that or removing the mention of the message is good to me - my problem is having info in the commit that is misleading, as this sequence of statements never led to this specific error message. It is better to remove comments than state something false. -- To view, visit http://gerrit.cloudera.org:8080/24590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 Gerrit-Change-Number: 24590 Gerrit-PatchSet: 11 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2026 12:10:26 +0000 Gerrit-HasComments: Yes
