Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 )
Change subject: IMPALA-6202. mod and % are not equivalent. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11443/1/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test File testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test: http://gerrit.cloudera.org:8080/#/c/11443/1/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test@516 PS1, Line 516: # IMPALA-6202 - mod and % are not equivalent. rather than talk about how the old code used to work, it'd be better to word this in the way the code should work: "MOD and % should be equivalent". The current wording could be interpreted to mean that they are currently not equivalent. -- To view, visit http://gerrit.cloudera.org:8080/11443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0067da04083859ffbf662a29007154461bea2ba Gerrit-Change-Number: 11443 Gerrit-PatchSet: 1 Gerrit-Owner: Yongjun Zhang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 14 Sep 2018 17:41:01 +0000 Gerrit-HasComments: Yes
